This adds a new experimental IVF format behind a feature flag #128631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>non-issue
test-release
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
mayya-sharipova
approved these changes
May 30, 2025
| ); | ||
|
|
||
| private static final int DEFAULT_VECTORS_PER_CLUSTER = 1000; | ||
| public static final int DYNAMIC_NPROBE = -1; |
There was a problem hiding this comment.
a comment here explaining what is DYNAMIC_PROBE and why is set to -1 would help
server/src/main/java/org/elasticsearch/index/mapper/vectors/DenseVectorFieldMapper.java
Show resolved
Hide resolved
| + CONTENT_TYPE | ||
| + "] fields with index type [" | ||
| + indexOptions.type | ||
| + "] with cannot be indexed if they're within [nested] mappings" |
There was a problem hiding this comment.
nit: drop the the second "with"
| num_candidates: 3 | ||
|
|
||
| - match: { hits.total: 3 } | ||
| - set: { hits.hits.0._score: raw_score0 } |
There was a problem hiding this comment.
How we are using raw_scores that we preserve here?
There was a problem hiding this comment.
Awe, bad copy paste I think. I fill fix
yeah, the current name is temporary, want to provide a better name before release. |
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
* Adding new bbq_ivf format behind a feature flag * adding tests * [CI] Auto commit changes from spotless * addressing pr comments * fixing flagging for yaml tests * adjust ivf search to utilize num candidates as approximation measure --------- Co-authored-by: elasticsearchmachine <[email protected]>
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
…c#128631) * Adding new bbq_ivf format behind a feature flag * adding tests * [CI] Auto commit changes from spotless * addressing pr comments * fixing flagging for yaml tests * adjust ivf search to utilize num candidates as approximation measure --------- Co-authored-by: elasticsearchmachine <[email protected]>
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…c#128631) * Adding new bbq_ivf format behind a feature flag * adding tests * [CI] Auto commit changes from spotless * addressing pr comments * fixing flagging for yaml tests * adjust ivf search to utilize num candidates as approximation measure --------- Co-authored-by: elasticsearchmachine <[email protected]>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…c#128631) * Adding new bbq_ivf format behind a feature flag * adding tests * [CI] Auto commit changes from spotless * addressing pr comments * fixing flagging for yaml tests * adjust ivf search to utilize num candidates as approximation measure --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for testing purposes only. That is why its behind a feature flag, the format will likely evolve and change significantly before release, breaking compatibility. Consequently, we have it locked behind a feature flag for the time being.